Use puppetlabs/stdlib to validate inputs.

.fixtures.yml

@@ -1,6 +1,6 @@
 fixtures:
   repositories:
-#    "stdlib": "git://github.com/puppetlabs/puppetlabs-stdlib.git"
+    "stdlib": "git://github.com/puppetlabs/puppetlabs-stdlib.git"
     "shell_config": "http://tig.csail.mit.edu/git-public/shell_config.git/"
   symlinks:
     "smartd": "#{source_dir}"

Modulefile

@@ -11,3 +11,4 @@ for detecting and identifying disks hiding behind an LSI MegaRAID/Dell PERC
 RAID controller (currently only implemented for Linux).'
 project_page 'http://tig.csail.mit.edu/wiki/TIG/PuppetAtCSAIL'
 dependency 'csail/shell_config', '>= 0.0.1'
+dependency 'puppetlabs/stdlib', '>=2.3.0'

manifests/init.pp

@@ -121,6 +121,19 @@
               $warning_schedule   = $smartd::params::warning_schedule,
               $enable_monit       = $smartd::params::enable_monit,
             ) inherits smartd::params {
+  # Validate our booleans
+  validate_bool($autoupdate)
+  validate_bool($devicescan)
+  validate_bool($enable_monit)
+
+  # Validate our hashs
+  validate_hash($device_opts)
+
+  # Validate our regexs
+  $states = [ '^daily$', '^once$', '^diminishing$', ]
+  validate_re($warning_schedule, $states,
+    '$warning_schedule must be either daily, once, or diminishing.')
+
   case $ensure {
     'present': {
       if $autoupdate {