Skip to content

Commit

Permalink
rename smartd::defaults -> smartd::params
Browse files Browse the repository at this point in the history
To better adhere to the current defacto naming conventions.
  • Loading branch information
Joshua Hoblitt committed May 15, 2013
1 parent 65fdc06 commit 096eb58
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 16 deletions.
3 changes: 1 addition & 2 deletions Rakefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
require 'puppetlabs_spec_helper/rake_tasks'
require 'puppet-lint/tasks/puppet-lint'

#PuppetLint.configuration.send("disable_class_inherits_from_params_class")
#PuppetLint.configuration.send("disable_variable_scope")
PuppetLint.configuration.send("disable_class_inherits_from_params_class")
PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", 'tests/**/*.pp']

task :default => [:spec, :lint]
24 changes: 12 additions & 12 deletions manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -100,18 +100,18 @@
#

class smartd ($ensure = 'present',
$autoupdate = $smartd::defaults::autoupdate,
$package_name = $smartd::defaults::package_name,
$service_name = $smartd::defaults::service_name,
$config_file = $smartd::defaults::config_file,
$devicescan = $smartd::defaults::devicescan,
$devicescan_options = $smartd::defaults::devicescan_options,
$devices = $smartd::defaults::devices,
$device_opts = $smartd::defaults::device_opts,
$mail_to = $smartd::defaults::mail_to,
$warning_schedule = $smartd::defaults::warning_schedule,
$enable_monit = $smartd::defaults::enable_monit,
) inherits smartd::defaults {
$autoupdate = $smartd::params::autoupdate,
$package_name = $smartd::params::package_name,
$service_name = $smartd::params::service_name,
$config_file = $smartd::params::config_file,
$devicescan = $smartd::params::devicescan,
$devicescan_options = $smartd::params::devicescan_options,
$devices = $smartd::params::devices,
$device_opts = $smartd::params::device_opts,
$mail_to = $smartd::params::mail_to,
$warning_schedule = $smartd::params::warning_schedule,
$enable_monit = $smartd::params::enable_monit,
) inherits smartd::params {
case $ensure {
'present': {
if $autoupdate {
Expand Down
4 changes: 2 additions & 2 deletions manifests/defaults.pp → manifests/params.pp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# == Class: smartd::defaults
# == Class: smartd::params
#
# Provides parameters for the smartd module
#
Expand All @@ -13,7 +13,7 @@
# Copyright (C) 2013 Joshua Hoblitt
#

class smartd::defaults {
class smartd::params {
$autoupdate = false
$package_name = 'smartmontools'
$service_name = 'smartd'
Expand Down

0 comments on commit 096eb58

Please sign in to comment.