Skip to content

Commit

Permalink
add megaraid_fw_version fact
Browse files Browse the repository at this point in the history
  • Loading branch information
Joshua Hoblitt committed Apr 29, 2014
1 parent 2d12260 commit 04d71cc
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 0 deletions.
13 changes: 13 additions & 0 deletions lib/facter/megaraid_fw_version.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Facter.add(:megaraid_fw_version) do
megacli = Facter.value(:megacli)

setcode do
unless megacli.nil?
output = Facter::Util::Resolution.exec("#{megacli} -Version -Ctrl -aALL")
next if output.nil?
m = output.match(/FW Version : ([\d\.\-]+)\s*$/)
next unless m.size == 2
m[1]
end
end
end
31 changes: 31 additions & 0 deletions spec/unit/facts/megaraid_fw_version_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
require 'spec_helper'

describe 'megaraid_fw_version', :type => :fact do
before(:each) { Facter.clear }

context 'megacli fact not set' do
it 'should return nil' do
Facter.fact(:megacli).stubs(:value).returns(nil)
Facter.fact(:megaraid_fw_version).value.should be_nil
end
end

context 'megacli fact is broken' do
it 'should return nil' do
Facter.fact(:megacli).stubs(:value).returns('foobar')
Facter.fact(:megaraid_fw_version).value.should be_nil
end
end

context 'megacli fact is working' do
it 'should get the version string' do
Facter.fact(:megacli).stubs(:value).returns('/usr/bin/MegaCli')
Facter::Util::Resolution.stubs(:exec).
with('/usr/bin/MegaCli -Version -Ctrl -aALL').
returns(File.read(fixtures('megacli', 'version-ctrl-aall-8.07.07')))
Facter.fact(:megaraid_fw_version).value.should == '3.340.05-2939'
end
end

end

0 comments on commit 04d71cc

Please sign in to comment.