converting public to visibility #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original `true` or `false` setting for public used to set to repository visibility to private or public. This does exactly the same thing keeping the `public=false/true` configuration setting. Removing `public` configuration in favor of full `visibility` support (public, private, internal) will require additional work so for now this is a stop gap for samrocketman#118
|
@cdenneen thanks for your contribution. Can you close this PR and rexopen it to the development branch? See the contributing.md doc |
|
@samrocketman sorry missed this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
trueorfalsesetting for public used to set to repository visibility to private or public.This does exactly the same thing keeping the
public=false/trueconfiguration setting.Removing
publicconfiguration in favor of fullvisibilitysupport (public, private, internal) will require additional work so for now this is a stop gap for #118