Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make #117

Closed
slabon opened this issue Feb 24, 2017 · 14 comments
Closed

Can't make #117

slabon opened this issue Feb 24, 2017 · 14 comments

Comments

@slabon
Copy link

slabon commented Feb 24, 2017

I was about to do a clean install but
it seem go-ethereum repository have change a few hours ago...

build/env.sh go get -v ./...
github.com/gorilla/mux (download)
github.com/gorilla/context (download)
github.com/ethereum/go-ethereum (download)
Fetching https://gopkg.in/redis.v3?go-get=1
Parsing meta tags from https://gopkg.in/redis.v3?go-get=1 (status code 200)
get "gopkg.in/redis.v3": found meta tag main.metaImport{Prefix:"gopkg.in/redis.v3", VCS:"git", RepoRoot:"https://gopkg.in/redis.v3"} at https://gopkg.in/redis.v3?go-get=1
gopkg.in/redis.v3 (download)
Fetching https://gopkg.in/bsm/ratelimit.v1?go-get=1
Parsing meta tags from https://gopkg.in/bsm/ratelimit.v1?go-get=1 (status code 200)
get "gopkg.in/bsm/ratelimit.v1": found meta tag main.metaImport{Prefix:"gopkg.in/bsm/ratelimit.v1", VCS:"git", RepoRoot:"https://gopkg.in/bsm/ratelimit.v1"} at https://gopkg.in/bsm/ratelimit.v1?go-get=1
gopkg.in/bsm/ratelimit.v1 (download)
github.com/ethereum/ethash (download)
package github.com/ethereum/go-ethereum/logger: cannot find package "github.com/ethereum/go-ethereum/logger" in any of:
/usr/local/go/src/github.com/ethereum/go-ethereum/logger (from $GOROOT)
/home/pool/open-ethereum-pool/build/_workspace/src/github.com/ethereum/go-ethereum/logger (from $GOPATH)
package github.com/ethereum/go-ethereum/logger/glog: cannot find package "github.com/ethereum/go-ethereum/logger/glog" in any of:
/usr/local/go/src/github.com/ethereum/go-ethereum/logger/glog (from $GOROOT)
/home/pool/open-ethereum-pool/build/_workspace/src/github.com/ethereum/go-ethereum/logger/glog (from $GOPATH)
github.com/go-stack/stack (download)
github.com/mattn/go-colorable (download)
github.com/rcrowley/go-metrics (download)
Fetching https://gopkg.in/karalabe/cookiejar.v2/collections/prque?go-get=1
Parsing meta tags from https://gopkg.in/karalabe/cookiejar.v2/collections/prque?go-get=1 (status code 200)
get "gopkg.in/karalabe/cookiejar.v2/collections/prque": found meta tag main.metaImport{Prefix:"gopkg.in/karalabe/cookiejar.v2", VCS:"git", RepoRoot:"https://gopkg.in/karalabe/cookiejar.v2"} at https://gopkg.in/karalabe/cookiejar.v2/collections/prque?go-get=1
get "gopkg.in/karalabe/cookiejar.v2/collections/prque": verifying non-authoritative meta tag
Fetching https://gopkg.in/karalabe/cookiejar.v2?go-get=1
Parsing meta tags from https://gopkg.in/karalabe/cookiejar.v2?go-get=1 (status code 200)
gopkg.in/karalabe/cookiejar.v2 (download)
github.com/yvasiyarov/gorelic (download)
github.com/yvasiyarov/go-metrics (download)
github.com/yvasiyarov/newrelic_platform_go (download)
Makefile:10: recipe for target 'all' failed
make: *** [all] Error 1

@sammy007
Copy link
Owner

Me too. Investigating.

@sammy007
Copy link
Owner

ethereum/ethash#91

@bapparabi
Copy link

yes same iisue for me alos

@phucvinh52
Copy link

Seem "github.com/ethereum/go-ethereum/logger" is deleted.

@bapparabi
Copy link

so what is solution now

@sammy007
Copy link
Owner

Fork go-ethereum repo to your github account, revert breaking changes, replace all occurences of "import ethereum/go-ethereum/*" to your repo. Then make.

@bapparabi
Copy link

not gettign it ..can't it be done simply using some command

@sammy007
Copy link
Owner

It can be done simply by fixing broken ethash package. There is a Swiss company backed by several millions of dollars and full time developers to serve you, please ask them in this issue ethereum/ethash#91

@sammy007 sammy007 reopened this Feb 24, 2017
@slabon
Copy link
Author

slabon commented Feb 24, 2017

There is a Swiss company backed by several millions of dollars and full time developers to serve you, please ask them in this issue ethereum/ethash#91
LoL

Ok forked and reverted... Thank you for pointing at that...
Where do the occurence appear in /open-ethereum-pool ?

@sammy007
Copy link
Owner

sammy007 commented Feb 24, 2017

Search in all .go files. Or clone ethash repo and delete all code using logger. You don't need togger there. Would be simple. Then replace ethash imports in miner.go.

I am not going to fix it myself because I don't wanna introduce yet another useless fork. Must be fixed in official repo.

@slabon
Copy link
Author

slabon commented Feb 24, 2017

Will try that... Thanx!

@sammy007
Copy link
Owner

ethereum/ethash#92

So ethash fix was easy, it's better if you will replace ethash in miner.go to your own forked version with my fix.

@karalabe
Copy link

Sorry about this breakage, we're in the process of swapping loggers in go-ethereum and ethash depended on the old one. Will merge now.

@sammy007
Copy link
Owner

Fixed in ethash upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants