Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get_Symbols() fail #119

Open
hammerjoe opened this issue Jul 15, 2022 · 1 comment
Open

Get_Symbols() fail #119

hammerjoe opened this issue Jul 15, 2022 · 1 comment

Comments

@hammerjoe
Copy link

def get_symbols(self):

    return self._get('symbols', False)

Theres an error with the get_symbols call. It doesnt take the optional parameter to get the data for one token and it errors out with "too many parameters given.
As per the docs :

GET /api/v1/symbols

PARAMETERS
Param Type Description
market String [Optional] The trading market.

@rhubear25
Copy link

Seems like this lib is a disaster... basics don't work. Example below.... get_ticker & allTickers CODE MIXED.
(I've taken out the comments from the lib, so that the Proc is easier to read).

get_ticker Proc: accesses 'market/allTickers' API path.
There doesn't seem to be an allTickers Proc.
Not gonna bother posting separately, seems this lib is not maintained.

def get_ticker(self, symbol=None):

    data = {}
    tick_path = 'market/allTickers'
    if symbol is not None:
        tick_path = 'market/orderbook/level1'
        data = {
            'symbol': symbol
        }

    return self._get(tick_path, False, data=data)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants