-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appendix with placeholder text is mildly confusing #16
Comments
schneems
added a commit
to schneems/oss-template
that referenced
this issue
Nov 18, 2024
Remove the appendix so that the license file can be copied without modification. This prevents accidentally including any placeholders. Close salesforce#16
schneems
added a commit
to schneems/oss-template
that referenced
this issue
Nov 19, 2024
The Apache 2.0 license on the website shows that it ends after "END OF TERMS AND CONDITIONS" https://www.apache.org/licenses/LICENSE-2.0 ![](https://private-user-images.githubusercontent.com/59744/387383537-f56c8594-5c32-41d5-a5b7-f4a587125ca2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzIwNTE4MDcsIm5iZiI6MTczMjA1MTUwNywicGF0aCI6Ii81OTc0NC8zODczODM1MzctZjU2Yzg1OTQtNWMzMi00MWQ1LWE1YjctZjRhNTg3MTI1Y2EyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDExMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMTE5VDIxMjUwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQwOTNkODQzZTI2YmQ5ZGNlYTM5ZTAxOGNhY2Q4Y2I2ODQyNWVmNjM5YTUzMWRhZGY1YTc4MDNlZjY0NmNmMmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FvvHOgNE1RrLTHYCjNUcUv0iq8KyzfXgrZS6J4f7igg) Our https://github.com/salesforce/oss-template/blob/main/license_info.md also shows the license ending there: ![](https://private-user-images.githubusercontent.com/59744/387383715-c9a35e3c-160d-4d3a-96d5-7be07d548dec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzIwNTE4MDcsIm5iZiI6MTczMjA1MTUwNywicGF0aCI6Ii81OTc0NC8zODczODM3MTUtYzlhMzVlM2MtMTYwZC00ZDNhLTk2ZDUtN2JlMDdkNTQ4ZGVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDExMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMTE5VDIxMjUwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThmNDJmMWEzODg0NTZiNzdjZTkzOTMxYjQ1MTAxOTVjMGE4YmFlMmMxYjQzMGUxMzE2NmJlNzk2M2IwNGZiYzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.132uqpmlORqSqiuBnu16TlgDkiF-9k3nJ3slt6QZ91A) This text exists because it's been mistakenly copied and pasted from https://www.apache.org/licenses/LICENSE-2.0.txt where its intent seems to be reproducing the application instructions as seen on https://www.apache.org/licenses/LICENSE-2.0 rather than as text that's intended to be included in the license. Close salesforce#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current LICENSE.txt matches the "text version" of the license https://www.apache.org/licenses/LICENSE-2.0.txt which includes some text that's not actually in the apache license. Namely:
I originally committed the entire file to my repo, as I assume others have. I found at least one other instance of it with the placeholders included accidentally https://github.com/salesforce/CodeGen/blob/4ded15eea09163f2ec2e677d20226330a8d682ed/LICENSE.txt.
I filed an issue with that repo: salesforce/CodeGen#95. Please validate that my understanding is correct, that the section at the bottom is not needed (as it is intended for a single file distribution). If so, I suggest updating the contents of
LICENSE.txt
to match what we hope to see in licenses (by removing the appendix).The text was updated successfully, but these errors were encountered: