Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit author name and icon scope to a single thread in chat #7671

Closed
novoselt opened this issue Jul 6, 2024 · 2 comments
Closed

Limit author name and icon scope to a single thread in chat #7671

novoselt opened this issue Jul 6, 2024 · 2 comments

Comments

@novoselt
Copy link
Collaborator

novoselt commented Jul 6, 2024

The current logic with multiple messages from a single author seems to be: put author's name above the first message and author's icon to the left of the last message. This may make perfect sense, but I strongly object to this logic crossing framed threads!

The frames make it easy to ignore groups of messages, but with current handling it is possible to have messages "between threads" without any markers related to who has written them.

If each top level message was labeled with author name/icon, it could be too much, but I think still better than the current situation. One can also try to group together "top level messages without any replies to them".

@haraldschilly
Copy link
Contributor

I know what you mean, but replies were implemented exactly like that, and I didn't change this when I implemented collapsable threads. In any case, I know what needs to be done to fix this.

@williamstein
Copy link
Contributor

I'm closing this. Open it if you can make it much clearer, with screenshots, etc. I feel at this point things work pretty well. Also, maybe this was a side effect of how search used to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants