Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contracts endpoint by address #12

Open
1 of 4 tasks
moisses89 opened this issue Dec 9, 2024 · 0 comments · May be fixed by #31
Open
1 of 4 tasks

Add contracts endpoint by address #12

moisses89 opened this issue Dec 9, 2024 · 0 comments · May be fixed by #31
Assignees
Labels
enhancement New feature or request

Comments

@moisses89
Copy link
Member

moisses89 commented Dec 9, 2024

What is needed?

Implement the contracts endpoint by id following the same structure than https://safe-transaction-mainnet.safe.global/#/contracts/contracts_retrieve with multichain support.

Proposal multichain support

I would like to add the multichain support by default for this and other endpoints and filter by query param the chain that the client wants.
For example:
GET contracts/{address}/?chain_id=chain_id If chain_id is not used to filter the endpoint should return all the contract and abis for all the chains where the contract is supported.
If chain_id is used to filter just return the corresponding chain
Even we could think about add the chain_id as an array parameter to get a group of chains.

Tasks

  • Add the necessary models (chains, Contracts, Abis... )
  • Add the tests and factory for the added models
  • Add the endpoint contract by address
  • Add test for the implemented endpoint
@moisses89 moisses89 added the enhancement New feature or request label Dec 9, 2024
@Uxio0 Uxio0 assigned Uxio0 and moisses89 and unassigned Uxio0 Dec 9, 2024
This was referenced Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants