Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java client: use exceptions instead of null result #182

Open
s-u opened this issue Apr 6, 2022 · 1 comment
Open

Java client: use exceptions instead of null result #182

s-u opened this issue Apr 6, 2022 · 1 comment
Assignees

Comments

@s-u
Copy link
Owner

s-u commented Apr 6, 2022

Many parts of the internal protocol code such as RTalk and RConnection catch low-level exceptions and return null making lower-level error handling on the Java side hard (see also comments in #175). Way back the first client used null to signal errors, but then a general REngine client was created which introduced exceptions. However, the low-level Rserve code has not adopted it yet and it still catching them instead of creating the corresponding exceptions.

@s-u s-u added the enhancement label Apr 6, 2022
@s-u s-u self-assigned this Apr 6, 2022
@s-u
Copy link
Owner Author

s-u commented Apr 6, 2022

Related upstream: s-u/REngine#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant