Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin overwrites applicationDefaultJvmArgs #95

Open
tajobe opened this issue Feb 23, 2024 · 1 comment
Open

Plugin overwrites applicationDefaultJvmArgs #95

tajobe opened this issue Feb 23, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@tajobe
Copy link

tajobe commented Feb 23, 2024

Using the application plugin, applicationDefaultJvmArgs are inherited by the distribution, however applying this plugin causes those to be overwritten/ignored.

Without the plugin applied, I can set:

application {
    // ...
    applicationDefaultJvmArgs = listOf("-Dabc=123")
}

...and I see DEFAULT_JVM_OPTS='"-Dabc=123"' in the dist script. If I apply the plugin, that is removed/replaced with EG DEFAULT_JVM_OPTS="-javaagent:$APP_HOME/agent-libs/opentelemetry-javaagent-2.1.0.jar" despite the arg still being in my application block. It would be nice for these to play nice as that's an easy way to globally set default opts for all tasks/everywhere the application is used.

@ryandens
Copy link
Owner

Thanks @tajobe! I thought i had a test case for this, but clearly not, i'll work on a patch for this when I get the opportunity (happy to accept a contribution for this as well)

@ryandens ryandens added the help wanted Extra attention is needed label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants