We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@dtex @rwaldron Hello guys, hope you're well.
When using the Animation API there is no way out from onloop callback using animation.next
onloop
animation.next
The next function is watch for isRunning === true and prevent going to next.
next
isRunning === true
johnny-five/lib/animation.js
Lines 85 to 91 in 094bf6c
If we call pause right before, this is not working too because it doesn't turn running false.
pause
running
Lines 125 to 138 in 094bf6c
if we call stop we clear the stack because this
stop
Line 150 in 094bf6c
So we can't go to the next animation.
Only solution is to call stop and trigger a new animation from within the callback.
oncomplete callback is not called for current animation when using stop(). But it only call onStop
oncomplete
stop()
onStop
Maybe we could think about something else ?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
@dtex @rwaldron
Hello guys, hope you're well.
First issue
When using the Animation API there is no way out from
onloop
callback usinganimation.next
The
next
function is watch forisRunning === true
and prevent going to next.johnny-five/lib/animation.js
Lines 85 to 91 in 094bf6c
If we call
pause
right before, this is not working too because it doesn't turnrunning
false.johnny-five/lib/animation.js
Lines 125 to 138 in 094bf6c
if we call
stop
we clear the stack because thisjohnny-five/lib/animation.js
Line 150 in 094bf6c
So we can't go to the next animation.
Only solution is to call
stop
and trigger a new animation from within the callback.Second issue
oncomplete
callback is not called for current animation when usingstop()
. But it only callonStop
Maybe we could think about something else ?
The text was updated successfully, but these errors were encountered: