From 4888e85df1a63efb65d564265eb64d5736b93fbe Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 21 Sep 2023 17:49:07 +0530 Subject: [PATCH] fix: Add more usable fieldtypes to group by (#22497) - Autocomplete is same as select - Dynamic link is same as link - Date is useful too Possible improvement `group by date(datetime)` (not part of this PR) --- frappe/public/js/frappe/ui/group_by/group_by.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/ui/group_by/group_by.js b/frappe/public/js/frappe/ui/group_by/group_by.js index 7b58f9c938c..a5e226122f1 100644 --- a/frappe/public/js/frappe/ui/group_by/group_by.js +++ b/frappe/public/js/frappe/ui/group_by/group_by.js @@ -364,7 +364,16 @@ frappe.ui.GroupBy = class { this.all_fields = {}; const fields = this.report_view.meta.fields.filter((f) => - ["Select", "Link", "Data", "Int", "Check"].includes(f.fieldtype) + [ + "Select", + "Link", + "Data", + "Int", + "Check", + "Dynamic Link", + "Autocomplete", + "Date", + ].includes(f.fieldtype) ); const tag_field = { fieldname: "_user_tags", fieldtype: "Data", label: __("Tags") }; this.group_by_fields[this.doctype] = fields