Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid aws-lc-rs feature flag when building docs. #273

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

tobz
Copy link
Contributor

@tobz tobz commented Apr 26, 2024

As stated in the title.

Mimics the fix in rustls/rustls#1827 by simply enabling all features manually, minus aws-lc-rs. This avoids trying to build it at in during docs.rs generation, as docs.rs can't currently compile it, whether or not FIPS is enabled.

There's nothing in the API, though, that depends on the feature flag so we didn't have to do anything in the code itself to cope with not passing the aws-lc-rs feature flag when building docs.

Tested locally using the docs.rs build instructions and verified that the build was broken prior to this fix, and the build completed successfully with this fix.

Fixes #272.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Cargo.toml Outdated Show resolved Hide resolved
@djc djc merged commit 78d214b into rustls:main Apr 26, 2024
11 checks passed
@djc
Copy link
Member

djc commented Apr 26, 2024

Bypassed queue in order to squash during merge.

@tobz tobz deleted the tobz/fix-broken-docs-aws-lc-fips branch April 26, 2024 13:19
@djc djc mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version (0.27.1) fails to build for docs.rs
3 participants