-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom server name resolution #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly looking good, here's a bunch of suggestions.
What's your use case for this?
My specific use case is performing client-side load-balancing against a headless service in Kubernetes. In a headless service, the cluster publishes a DNS record mapping e.g. To make this work, cleanest way seems to be to rewrite the URI to include both the hostname and IP. I can then create a custom DNS resolver for the Hyper client which pull the IP out of the URI, and a custom servername resolver in hyper-rustls that pulls the hostname out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Will take a look soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me. I had a couple of non-blocking suggestions to consider.
Co-authored-by: Daniel McCarney <[email protected]>
@djc should we cut a release for this? |
I was defaulting to not doing so (proactively) unless the OP asks for it. |
A release would be appreciated :) |
In progress: #270 |
I don't love the duplication of the ipv6 handling. We could have
resolve
just return a String and do the conversion in the connector maybe?Closes #195