Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export TlsAcceptor from server example #185

Closed
Licenser opened this issue Jan 19, 2023 · 4 comments
Closed

export TlsAcceptor from server example #185

Licenser opened this issue Jan 19, 2023 · 4 comments

Comments

@Licenser
Copy link
Contributor

Hi,

the create exports the tools for a extremely pleasant interface to create a hyper client but to use it with a server requires quite a bit of extra work that is hidden away in examples/server.rs. Would there be a chance to make the TlsAcceptor a part of the crates API to make servers as pleasant to build as clients? :)
@djc
Copy link
Member

djc commented Jan 19, 2023

I guess that might make sense. In my mind it was maybe too opinionated, but maybe not. Would you be able to submit a PR?

@Licenser
Copy link
Contributor Author

Yay! Absolutely would love to :) just didn't wanted to do that before looking if it is accepted. I'll do that up tomorrow

@Licenser
Copy link
Contributor Author

Submitted #186 to resolve this

@Licenser
Copy link
Contributor Author

resolving this as the pr was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Licenser @djc