-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only emit debug info when asked #378
Comments
Good. Feel free to ask any questions if you need help. |
@antoyo if i understand the config.rs file correctly RUSTFLAGS is what collect all the the environment variables and join them into string, thus removing the "-Cdebuginfo=2" from vector, mean the debug option will not get emitted |
The standard library shipped with rustup is built with |
@bjorn3 i see, does this mean, |
|
This will emit all debug info, though, so we might as well change this to:
@mubarak23: Could you please add this change to your PR? |
@antoyo i will add it to the PR and push |
PR updated with changes requested @antoyo |
Thanks a lot! I'll merge it when the CI is done. |
Done in antoyo#1. |
Currently, debug info is always emmited.
context.set_debug_info(true);
should not always be called insrc/base.rs
.-Cdebuginfo=2
should probably not be always added inbuild_system/src/config.rs
.The text was updated successfully, but these errors were encountered: