Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest "--bless" fails to delete stderr files #134793

Open
RalfJung opened this issue Dec 26, 2024 · 0 comments · May be fixed by #134808
Open

compiletest "--bless" fails to delete stderr files #134793

RalfJung opened this issue Dec 26, 2024 · 0 comments · May be fixed by #134808
Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

I made a mistake during compiler development so that a "--bless" run (./x test ui --bless -- feat) ended up generating a bunch of stderr files for compiler runs that shouldn't fail. I fixed that mistake, but unfortunately "--bless" does not remove these files. It seems I have to delete them all by hand.

That's not great; if "--bless" creates new files then it should also clean them up by itself.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 26, 2024
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-compiletest Area: The compiletest test runner and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 26, 2024
@clubby789 clubby789 linked a pull request Dec 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
compiletest maintenance and improvements
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compiletest: Remove empty 'expected' files when blessing clubby789/rust
3 participants
@RalfJung @jieyouxu @rustbot