Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro string literal completion edits not replacing prior text #17479

Open
RoloEdits opened this issue Jun 22, 2024 · 1 comment
Open

Macro string literal completion edits not replacing prior text #17479

RoloEdits opened this issue Jun 22, 2024 · 1 comment
Labels
A-completion autocompletion A-proc-macro proc macro C-bug Category: bug E-easy

Comments

@RoloEdits
Copy link

rust-analyzer version: rust-analyzer 0.0.0 (498b94b730 2024-06-17)

rustc version: rustc 1.74.0 (79e9716c9 2023-11-13)

editor or extension: helix

code snippet to reproduce:

// add your code here
use chrono::serde::ts_milliseconds;
use chrono::{DateTime, Utc};
use serde::Deserialize;

#[derive(Deserialize)]
struct A {
    #[serde(with = "ts_mill")]
    time: DateTime<Utc>,
}

fn main() {
    println!("Hello, world!");
}

helix_auto_complete_in_string

Originally thought it was a helix issue, but was directed here after some discussion.
helix-editor/helix#11020

@RoloEdits RoloEdits added the C-bug Category: bug label Jun 22, 2024
@Veykril
Copy link
Member

Veykril commented Jun 22, 2024

Hmm, we shouldn't trigger those there at all actually given we are inside a string token. It's not really possibly for us to treat this completion correctly inside a string.

@Veykril Veykril added E-easy A-completion autocompletion A-proc-macro proc macro labels Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion autocompletion A-proc-macro proc macro C-bug Category: bug E-easy
Projects
None yet
Development

No branches or pull requests

2 participants