Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add f16 and f128 support (add to FloatTy) #17451

Open
tgross35 opened this issue Jun 19, 2024 · 3 comments
Open

Add f16 and f128 support (add to FloatTy) #17451

tgross35 opened this issue Jun 19, 2024 · 3 comments
Labels
A-chalk chalk related issue A-ty type system / type inference / traits / method resolution C-feature Category: feature request

Comments

@tgross35
Copy link

FloatTy in rustc has f16 and f128 now. It would probably be pretty easy to update RA's FloatTy to match and propagate that out.
@tgross35 tgross35 added the C-feature Category: feature request label Jun 19, 2024
@tgross35 tgross35 mentioned this issue Jun 19, 2024
Open
3 tasks
@tgross35
Copy link
Author

Probably pretty easy

@rustbot label +E-easy +A-hir

@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2024

Error: Label E-easy can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@Veykril
Copy link
Member

Veykril commented Jun 19, 2024

That will require changes to chalk

@Veykril Veykril added A-ty type system / type inference / traits / method resolution A-chalk chalk related issue labels Jun 19, 2024
@beetrees beetrees mentioned this issue Jun 24, 2024
Merged
bors added a commit to rust-lang/chalk that referenced this issue Jun 24, 2024
@bors
Auto merge of #811 - beetrees:f16-f128, r=jackh726
77406aa 
Add `f16` and `f128`

Needed for rust-lang/rust-analyzer#17451.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-chalk chalk related issue A-ty type system / type inference / traits / method resolution C-feature Category: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Veykril @tgross35 @rustbot