Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Default::default() for arrsac::Config #1

Open
jerry73204 opened this issue Jan 5, 2020 · 2 comments
Open

Implement Default::default() for arrsac::Config #1

jerry73204 opened this issue Jan 5, 2020 · 2 comments

Comments

@jerry73204
Copy link
Contributor

I see the suggested parameters on Config doc. It would be reasonable to implement Default trait for Config. That would give us some convenience to create this struct.
@vadixidav
Copy link
Member

vadixidav commented Jan 6, 2020 •
edited
Loading

@jerry73204 The inlier threshold is specific to your dataset and should be provided as a parameter to new. I will leave this ticket open though as that should be added to the documentation.

@jerry73204
Copy link
Contributor Author

jerry73204 commented Jan 6, 2020 •
edited
Loading

EDIT: I missed the new() method there, and yes it's more like a doc issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jerry73204 @vadixidav