Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Upstream #89

Closed
wants to merge 1,057 commits into from
Closed

Conversation

brauliobz
Copy link

@brauliobz brauliobz commented Jan 28, 2020

Resolve #88 .

Alguns detalhes importantes:

  • Na nova versão, uma boa parte dos trechos de código agora ficam em arquivos separados (pasta /listings). Mantive as traduções com trechos de código inline.
  • Eu coloquei de volta os parágrafos em inglês em alguns arquivos (fica melhor de revisar e atualizar), mas não fiz isso em todos.
  • O capítulo 07 foi reestruturado e, com isso, mantive as seções antigas (traduzidas) e as novas ainda em inglês.
  • Limitei a 80 colunas algumas das traduções já feitas.

NanXiao and others added 30 commits April 25, 2019 10:43
> First, in Listing 16-6, we’ll create a channel but not do anything with it.
Note that this won’t compile yet because Rust can’t tell what type of values we
want to send over the channel.

That was not true, however, since the code compiled due to hidden line.
This change makes the code not compile by removing it.
Update install instructions for VS 2019
This seems like a typo to me :
...similar to the concept      duck typing in dynamically...
...similar to the concept *of* duck typing in dynamically...
The compiler will call `into_iter()` on the values.
To keep the wording consistent with the first paragraph. It's a little bit confusing to use the word test here since it can be mistaken as a test function.
@brauliobz brauliobz marked this pull request as ready for review January 28, 2020 19:35
@brauliobz brauliobz changed the title WIP: Update from Upstream Update from Upstream Jan 28, 2020
@marioidival marioidival requested review from cpswsg and a team January 29, 2020 14:10
@marioidival
Copy link
Member

@rust-br/traducao alguem que fez trabalho aqui tem como ver se houve problemas? 🤔

@evaporei
Copy link
Member

evaporei commented Feb 5, 2020

Então @brauliobz agradeço muito o PR de verdade, mas acredito não ser muito viável alguém conseguir revisar +1000 commits com +2400 arquivos alterados 😕

Será que existe alguma forma de fazermos a mesma coisa em partes para facilitar a revisão?

@brauliobz
Copy link
Author

Sim, claro. Vou dividir e fazer outros PRs.

@brauliobz brauliobz closed this Feb 8, 2020
@brauliobz brauliobz mentioned this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UPDATE COM UPSTREAM