Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to tag the next v1.x version of Blackfriday so that Hugo can use it #550

Open
kaushalmodi opened this issue Jun 16, 2019 · 1 comment

Comments

@kaushalmodi
Copy link

kaushalmodi commented Jun 16, 2019

Ref: gohugoio/hugo#6040


Hello,

I discovered this issue recently from this comment in the Hugo Discourse forum.

The issue is that for a Markdown snippet:

-   list item 1
    ```md
    *hello*
    ```
-   list item 2

list item 2 now gets nested under list item 1.

This issue wasn't there until Hugo v0.55.5. The last good Hugo version without this regression is v0.55.4.

Recreating this issue is very easy; just clone the below repo and run it with Hugo v0.55.4 vs Hugo v0.55.5, and see the difference:

My best bet is that this commit in Blackfriday caused this regression.

The regression was seen in Hugo in v0.55.5, because it's in that version that Blackfriday version was bumped to version v1.5.2 in this commit.


Example snippet

-   List item 1

    ```md
    *abc*
    /def/
    =def=
    ```
-   List item 2

Rendering of above in Hugo v0.55.4

<ul>
<li><p>List item 1</p>

<pre><code class="language-md">*abc*
/def/
=def=
</code></pre></li>

<li><p>List item 2</p></li>
</ul>
  • List item 1

    *abc*
    /def/
    =def=
    
  • List item 2

Rendering of above in Hugo v0.55.5 (regression)

<ul>
<li><p>List item 1</p>

<pre><code class="language-md">*abc*
/def/
=def=
</code></pre>

<ul>
<li>List item 2</li>
</ul></li>
</ul>
  • List item 1

    *abc*
    /def/
    =def=
    
    • List item 2

/cc @aignas Can you review if your Blackfriday commit referenced above caused this regression and can you please fix it?

@aignas
Copy link
Contributor

aignas commented Jun 16, 2019

I think this is a duplicate of #495, see the referenced hugo issue.

@kaushalmodi kaushalmodi changed the title Regression: Issue with rendering plain lists and code blocks Request to tag the next v1.x version of Blackfriday so that Hugo can use it Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants