Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not dumping users with guest role #108

Open
jagarop opened this issue Aug 16, 2022 · 4 comments
Open

not dumping users with guest role #108

jagarop opened this issue Aug 16, 2022 · 4 comments
Labels
API API related issue EDGE enhancement New feature or request
Milestone

Comments

@jagarop
Copy link

jagarop commented Aug 16, 2022

Describe the bug
Guest users information is not being dumped to users.json.

To Reproduce
Steps to reproduce the behavior:

  1. Join a workspace with guest/multi-channel guest users
  2. Dump it
  3. Check users.json
  4. All their messages will show with only their ID in a full dump, and users.json doesn't have a record for those users.

Expected behavior
Populated guest users in users.json

Output
Not applicable

Desktop (please complete the following information):

  • OS: [Windows 10 x64]

Additional context
I tested this in a workspace that have about 400 normal users and 2000 guests. Got data for all normal users and no data from guests. It shows fine in browser/slack desktop client.

@rusq
Copy link
Owner

rusq commented Aug 17, 2022

Hey @jagarop, I'm trying to reproduce this, as my test workspace is on free account, I'm not able to invite guests, but I have one workspace where I have a guest account.

What I've done so far - I exported a workspace where I'm a "guest", and users.json indeed does not contain some of the users, which are present in the channel conversations, and are resolved correctly by slack client.

I'll see how this can be addressed.

@jagarop
Copy link
Author

jagarop commented Aug 18, 2022

Hey @jagarop, I'm trying to reproduce this, as my test workspace is on free account, I'm not able to invite guests, but I have one workspace where I have a guest account.

What I've done so far - I exported a workspace where I'm a "guest", and users.json indeed does not contain some of the users, which are present in the channel conversations, and are resolved correctly by slack client.

I'll see how this can be addressed.

Hello @rusq, thanks for taking a look at this issue, really apreciate!

If you need anything else from me that would help on this matter, please let me know.

@rusq
Copy link
Owner

rusq commented Aug 19, 2022

So I investigated quite a bit on this - the Slack Client calls a set of undocumented Slack edge APIs in order to retrieve the names of the users. I'm currently experimenting with this and made some progress, but it's far from completion. It is the same APIs that mentioned in #64. I'm parking it for now, as I think that implementing Mattermost export compatibility would take less time, and there's a high demand on that right now, as people are migrating from Slack to Mattermost (#107).

I can only guess, that the reason that Slack does not return a complete set of users using the standard API and client token is that it does not expect someone to call standard Slack APIs under the guest account.

@rusq rusq added API API related issue enhancement New feature or request labels Aug 28, 2022
@rusq rusq added the EDGE label Oct 16, 2022
@rusq
Copy link
Owner

rusq commented Nov 24, 2024

Tested this with edge, the behaviour is the same - doesn't return all users, only those which guest has interacted with. Will need to check that kind of requests the browser sends, maybe it's possible to replicate.

@rusq rusq added this to the v3.1 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issue EDGE enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants