-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to add custom ingress rule for ssl #58
Comments
I have the same problem, did you manage to solve it? |
Don't the current ingress rules allow for overriding the highlighted parameters in the above screenshot? Please confirm if this is still an issue. https://github.com/runatlantis/helm-charts/blob/main/charts/atlantis/templates/ingress.yaml |
@nitrocode I have this declared in my values.yaml
And I'm getting:
btw I'm using helmfile to render the templates since it's easier for me. If you have any doubts please let me know |
by the other hand if I have a cluster with networking.k8s.io/v1 apiVersion I can do the following:
Which leads me to suggest to close this issue since the AWS ALB v2.4 official documentation is updated to v1 |
The value helm-charts/charts/atlantis/values.yaml Lines 213 to 214 in a4e4678
So helm-charts/charts/atlantis/templates/ingress.yaml Lines 1 to 9 in a4e4678
This is the block that controls whether to use the old helm-charts/charts/atlantis/templates/ingress.yaml Lines 57 to 66 in a4e4678
According to this doc, you should be using ingress:
apiVersion: extensions/v1beta1 |
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.' |
We're using alb controller, and we need to add additional rule for ssl
The text was updated successfully, but these errors were encountered: