core: Hide focus highlight on invalid and empty bounds #17037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17034.
Flash Player has a fairly complicated, implementation-dependent behavior related to degenerate bounds and bounds that change after being highlighted. It seems that the highlight is hidden when there's nothing to be rendered:
Sometimes highlight is not updated after highlight bounds change, but this behavior is rare and inconsistent, it even differs depending on when the update happens.
However, the most common case of depending on the behavior above is when the SWF creates a movie clip, focuses it, and then adds some content to it. In that case FP will not render the highlight (even if in theory it should). Hiding focus highlight on invalid and empty bounds covers this case, but:
However, I've never seen these cases in real SWFs, only during testing.