Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the GitHub checks API #89

Open
Manfred opened this issue Nov 29, 2019 · 7 comments
Open

Investigate the GitHub checks API #89

Manfred opened this issue Nov 29, 2019 · 7 comments

Comments

@Manfred
Copy link
Collaborator

Manfred commented Nov 29, 2019

We're looking for a way to allow easy interaction between Perf Check and GitHub pull requests. It's possible that the checks API is a fit even though Perf Check is not a traditional CI service.

@Manfred
Copy link
Collaborator Author

Manfred commented Nov 29, 2019

  • Can we link back to a useful view with the 'details' link in the checks summary? No

@Manfred
Copy link
Collaborator Author

Manfred commented Dec 2, 2019

The Details link always goes to the relevant check. In other words, this:

Screen Shot 2019-12-02 at 16 19 53

Links to this:

Screen Shot 2019-12-02 at 16 20 35

And View more details link on that page links to the details_url set for the check run.

@Manfred
Copy link
Collaborator Author

Manfred commented Dec 2, 2019

Other ideas of things you can create on a PR:

  • Reactions: +1, -1, laugh, confused, heart, hooray, rocket, and eyes (can also be deleted)
  • PR Reviews: "Things are faster!"

Unfortunately none of these allow you to easily link back to PerfCheck. The only ways to link back to PerfCheck seems to be to create or edit a Check or a Comment.

@sudara
Copy link
Member

sudara commented Dec 2, 2019

Hmmm, I wonder how CircleCI achieves their direct link to circleci.com from the checks interface?

@sudara
Copy link
Member

sudara commented Dec 2, 2019

Maybe they purposefully don't use the new checks API unless you opt-in to it: https://circleci.com/docs/2.0/enable-checks/

@sudara
Copy link
Member

sudara commented Dec 2, 2019

It might be helpful to separate these two needs:

  1. Get notified of git pushes to a branch or PR that we care about, that may or may not contain metadata that can trigger a Perf Check Job

  2. Find a way to advertise Perf Check on a PR to ease discoverability.

@Manfred
Copy link
Collaborator Author

Manfred commented Dec 3, 2019

Ah yes, the current way of implementing checks is by using the Status API. You register a webhook and then use the Status API to set a status for a commit sha. That has a target URL to link back to the CI. I'm guessing they'll show the statuses for the last commit in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants