Merge pull request #206 from juresyahya/perf_improv

Performance Improvement when querying tags on model especially for models with lots of records and with tags
rtconner · Mar 28, 2022 · 4645bf6 · 4645bf6
2 parents c3a299f + 758f551
commit 4645bf6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Taggable.php b/src/Taggable.php
@@ -205,7 +205,8 @@ public function scopeWithAllTags(Builder $query, $tagNames): Builder
                 ->where('tag_slug', TaggingUtility::normalize($tagSlug))
                 ->where('taggable_type', $className)
                 ->get()
-                ->pluck('taggable_id');
+                ->pluck('taggable_id')
+                ->unique();
 
             $primaryKey = $this->getKeyName();
             $query->whereIn($this->getTable().'.'.$primaryKey, $tags);
@@ -401,7 +402,8 @@ private function assembleTagsForScoping($query, $tagNames)
             ->whereIn('tag_slug', $tagNames)
             ->where('taggable_type', $className)
             ->get()
-            ->pluck('taggable_id');
+            ->pluck('taggable_id')
+            ->unique();
 
         return $tags;
     }