Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating RSC_VERSION fails on MacOS #790

Open
dbkegley opened this issue Jun 3, 2024 · 0 comments
Open

Updating RSC_VERSION fails on MacOS #790

dbkegley opened this issue Jun 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dbkegley
Copy link
Contributor

dbkegley commented Jun 3, 2024

During the latest release of Connect we found that our release automation break when run on MacOS due to this line:

sed -i '/variable CONNECT_VERSION/!b;n;c\ \ \ \ default = "{{ RSC_VERSION }}"' docker-bake.hcl

just RSC_VERSION=2024.05.1 update-rsc-versions
+ sed -i '' 's/RSC_VERSION=.*/RSC_VERSION=2024.05.1/g' connect/.env connect/Dockerfile.ubuntu2204 connect-content-init/Dockerfile.ubuntu2204
+ sed -i '' 's/^RSC_VERSION := .*/RSC_VERSION := "2024.05.1"/g' Justfile
++ just _get-clean-version 2024.05.1
+ sed -i '' -E 's/[0-9]{4}\.[0-9]{1,2}\.[0-9]{1,2}/2024.05.1/g' connect/README.md connect-content-init/README.md
+ sed -i '/variable CONNECT_VERSION/!b;n;c\ \ \ \ default = "2024.05.1"' docker-bake.hcl
sed: 1: "docker-bake.hcl": extra characters at the end of d command
error: Recipe `update-rsc-versions` failed with exit code 1

We tried replacing the -i with {{ sed_vars }} but that doesn't seem to fix the issue either. Something to do with the new !b;n;c isn't playing nicely with BSD sed on mac. Right now we can only run this automation on Linux but most of our developers responsible for releases are on mac.

@dbkegley dbkegley added the bug Something isn't working label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant