Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dima/cleanup #247

Open
wants to merge 2 commits into
base: melodic-devel
Choose a base branch
from
Open

Dima/cleanup #247

wants to merge 2 commits into from

Conversation

dorezyuk
Copy link

@dorezyuk dorezyuk commented Nov 9, 2020

PR cleans up the code a little bit:

  1. remove unused getError methods and the definition imported by it (I suppose this was used some time ago and left here)
  2. remove the overwrite of resize, since g2o sets the all vertices already to 0. see
    https://github.com/RainerKuemmerle/g2o/blob/c64f79af4b7308a0505a05831f46e0dffb9a0c45/g2o/core/hyper_graph.cpp#L70
  3. add a config-interface, so we can reuse it in all base-edge classes (reduces the copy and paste code)

dorezyuk
dorezyuk commented Nov 9, 2020
View reviewed changes
include/teb_local_planner/g2o_types/base_teb_edges.h
struct ConfigInterface{

inline const TebConfig* getTebConfig() const noexcept
{
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getter actually not required, so it could be dropped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dorezyuk