Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the 3 dynamic reconfigure servers into one (retaining tabs) #45

Open
corot opened this issue Feb 3, 2022 · 2 comments
Open

Unify the 3 dynamic reconfigure servers into one (retaining tabs) #45

corot opened this issue Feb 3, 2022 · 2 comments

Comments

@corot
Copy link

corot commented Feb 3, 2022

Hi, this issue is both a question and a proposal.

question:
what are the benefits of splitting the dynamic reconfigurable parameters into 3 servers? The drawback I found is that we cannot treat MPC as any other local planner when changing generic parameters as the goal tolerances.

proposal:
replicate TEB architecture with a single server but multiple tabs, so parameters are neatly distributed on RQT reconfigure but still accessible under a predictably named server (we will PR the change if deemed opportune).

@kosmastsk
Copy link
Contributor

This change was introduced in #24 . The initial implementation contained only a single .cfg file for all dynamic reconfigure parameters.

@corot
Copy link
Author

corot commented Apr 13, 2022

I see the problem; but seems to me that PR #24 is adapting to the parameters namespace structure created with this example configuration

I think it would had been simpler to rewrite the configuration file declaring all MPC parameters in its own file and all the other parameters in a separated testing configuration. The 3 reconfigure servers looks rather overkilling to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants