Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing.mapToByteBuf uses wrong value length for writing to byteBuf #74

Open
creiterer opened this issue Jun 8, 2021 · 0 comments
Open

Comments

@creiterer
Copy link

Encoding the baggage items of a span context using DefaultMetadataEncoder.encode() can lead to an error if the baggage items are too huge to fit in the default buffer capacity (which seems to be 256).
The problem is that Tracing.mapToByteBuf uses keyLength instead of valueLength for writing value to byteBuf:

ByteBufUtil.reserveAndWriteUtf8(byteBuf, value, keyLength);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant