From d5105daf602d4587cd00440b3f9bc2b2663dbc68 Mon Sep 17 00:00:00 2001 From: Sidney Alcantara Date: Tue, 28 Sep 2021 21:42:34 +1000 Subject: [PATCH 01/15] UserItem: fix multiselect styles being overridden --- src/components/Settings/UserManagement/UserItem.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/Settings/UserManagement/UserItem.tsx b/src/components/Settings/UserManagement/UserItem.tsx index 5d42967ff..2221cd9ea 100644 --- a/src/components/Settings/UserManagement/UserItem.tsx +++ b/src/components/Settings/UserManagement/UserItem.tsx @@ -126,24 +126,24 @@ export default function UserItem({ id, user, roles: rolesProp }: User) { sx: { mr: 0.5, - "& .MuiInputLabel-root": { + "&& .MuiInputLabel-root": { opacity: 0, mt: -3, }, - "& .MuiFilledInput-root": { + "&& .MuiFilledInput-root": { bgcolor: "transparent", boxShadow: 0, "&::before": { content: "none" }, "&:hover, &.Mui-focused": { bgcolor: "action.hover" }, }, - "& .MuiSelect-select.MuiFilledInput-input": { + "&& .MuiSelect-select.MuiFilledInput-input": { typography: "button", pl: 1, pr: 3.25, }, - "& .MuiSelect-icon": { + "&& .MuiSelect-icon": { right: 2, }, }, From bc4a99d7fe70d5dd9a9b0f853671123f55343ea6 Mon Sep 17 00:00:00 2001 From: Sidney Alcantara Date: Tue, 28 Sep 2021 22:53:37 +1000 Subject: [PATCH 02/15] remove title case from UI text to follow google, microsoft & github style guides --- src/components/Auth/MarketingBanner.tsx | 2 +- src/components/CodeEditorHelper/index.tsx | 11 +---- .../ConnectServiceSelect/PopupContents.tsx | 2 +- src/components/EmptyState.tsx | 2 +- src/components/ErrorBoundary.tsx | 4 +- src/components/Home/AccessDenied.tsx | 4 +- src/components/Navigation/Breadcrumbs.tsx | 2 +- .../Navigation/Notifications/index.tsx | 2 +- .../Settings/ProjectSettings/About.tsx | 6 +-- .../ProjectSettings/Authentication.tsx | 2 +- .../Settings/ProjectSettings/RowyRun.tsx | 6 +-- src/components/Settings/ThemeColorPicker.tsx | 4 +- .../Settings/UserManagement/InviteUser.tsx | 8 ++-- .../Settings/UserManagement/UserItem.tsx | 4 +- .../Settings/UserSettings/Account.tsx | 2 +- src/components/Setup/Step1RowyRun.tsx | 4 +- src/components/Setup/Step2ServiceAccount.tsx | 4 +- src/components/Setup/Step3ProjectOwner.tsx | 4 +- src/components/Setup/Step4Rules.tsx | 6 +-- src/components/SideDrawer/Form/index.tsx | 2 +- src/components/Table/BulkActions/index.tsx | 8 ++-- src/components/Table/CellValidation.tsx | 4 +- src/components/Table/ColumnHeader.tsx | 6 +-- .../FieldSettings/DefaultValueInput.tsx | 2 +- .../Table/ColumnMenu/FieldSettings/index.tsx | 4 +- .../Table/ColumnMenu/FieldsDropdown.tsx | 4 +- .../Table/ColumnMenu/NameChange.tsx | 4 +- src/components/Table/ColumnMenu/NewColumn.tsx | 6 +-- .../Table/ColumnMenu/TypeChange.tsx | 2 +- src/components/Table/EmptyTable.tsx | 6 +-- src/components/Table/Filters/index.tsx | 4 +- src/components/Table/FinalColumnHeader.tsx | 2 +- src/components/Table/HiddenFields.tsx | 2 +- src/components/Table/Settings/Menu.tsx | 2 +- src/components/Table/Settings/Webhooks.tsx | 2 +- .../Table/Skeleton/HeaderRowSkeleton.tsx | 2 +- .../Table/Skeleton/TableHeaderSkeleton.tsx | 2 +- .../Table/TableHeader/Export/Download.tsx | 6 +-- .../Table/TableHeader/Export/Export.tsx | 4 +- .../Table/TableHeader/Export/index.tsx | 2 +- .../TableHeader/Extensions/ExtensionList.tsx | 2 +- .../Extensions/ExtensionMigration.tsx | 2 +- .../TableHeader/Extensions/ExtensionModal.tsx | 18 ++++---- .../Table/TableHeader/Extensions/index.tsx | 2 +- .../Table/TableHeader/ImportCsv.tsx | 4 +- .../Table/TableHeader/ReExecute.tsx | 4 +- .../Table/TableHeader/RowHeight.tsx | 6 +-- .../Table/TableHeader/TableLogs.tsx | 12 +++--- .../Table/TableHeader/TableSettings.tsx | 2 +- src/components/Table/TableHeader/index.tsx | 2 +- .../Table/formatters/FinalColumn.tsx | 8 ++-- src/components/Table/index.tsx | 2 +- src/components/TableSettings/form.tsx | 14 +++---- src/components/TableSettings/index.tsx | 8 ++-- .../Wizards/ImportCsvWizard/Step1Columns.tsx | 10 ++--- .../ImportCsvWizard/Step2NewColumns.tsx | 8 ++-- .../Wizards/ImportCsvWizard/index.tsx | 6 +-- .../Wizards/ImportWizard/Step1Columns.tsx | 4 +- .../Wizards/ImportWizard/Step2Rename.tsx | 4 +- .../Wizards/ImportWizard/Step3Types.tsx | 8 ++-- src/components/Wizards/ImportWizard/index.tsx | 8 ++-- src/components/fields/Action/Settings.tsx | 16 +++---- src/components/fields/Aggregate/Settings.tsx | 2 +- .../ConnectServiceSelect/PopupContents.tsx | 2 +- .../fields/ConnectService/Settings.tsx | 10 ++--- .../fields/ConnectTable/Settings.tsx | 10 ++--- src/components/fields/Derivative/Settings.tsx | 22 +++++----- .../fields/File/SideDrawerField.tsx | 2 +- src/components/fields/File/TableCell.tsx | 2 +- src/components/fields/ShortText/Settings.tsx | 4 +- .../fields/SingleSelect/Settings.tsx | 6 +-- src/components/fields/Slider/Settings.tsx | 8 ++-- src/components/fields/Status/Settings.tsx | 42 ++++++++++--------- src/components/fields/SubTable/Settings.tsx | 2 +- src/hooks/useTable/useTableData.tsx | 2 +- src/pages/Auth/ImpersonatorAuth.tsx | 4 +- src/pages/Auth/JwtAuth.tsx | 2 +- src/pages/Auth/SetupGuide.tsx | 4 +- src/pages/Auth/SignOut.tsx | 4 +- src/pages/Auth/SignUp.tsx | 2 +- src/pages/Auth/index.tsx | 2 +- src/pages/Deploy.tsx | 2 +- src/pages/Home.tsx | 8 ++-- src/pages/PageNotFound.tsx | 6 +-- src/pages/RowyRunTest.tsx | 2 +- src/pages/Settings/UserManagement.tsx | 4 +- src/pages/Setup.tsx | 16 +++---- 87 files changed, 236 insertions(+), 239 deletions(-) diff --git a/src/components/Auth/MarketingBanner.tsx b/src/components/Auth/MarketingBanner.tsx index bc0f91d74..200213343 100644 --- a/src/components/Auth/MarketingBanner.tsx +++ b/src/components/Auth/MarketingBanner.tsx @@ -76,7 +76,7 @@ export default function MarketingBanner() { target="_blank" rel="noopener noreferrer" > - Join our Community + Join our community ); diff --git a/src/components/ConnectServiceSelect/PopupContents.tsx b/src/components/ConnectServiceSelect/PopupContents.tsx index cfd77e597..0b6b71c7e 100644 --- a/src/components/ConnectServiceSelect/PopupContents.tsx +++ b/src/components/ConnectServiceSelect/PopupContents.tsx @@ -194,7 +194,7 @@ export default function PopupContents({ color="primary" className={classes.selectAllButton} > - Clear Selection + Clear selection diff --git a/src/components/EmptyState.tsx b/src/components/EmptyState.tsx index 6ac2a78d0..11e28d992 100644 --- a/src/components/EmptyState.tsx +++ b/src/components/EmptyState.tsx @@ -29,7 +29,7 @@ export interface IEmptyStateProps extends Partial { * Override with props that are passed to the root MUI `Grid` component. */ export default function EmptyState({ - message = "Nothing Here", + message = "Nothing here", description, Icon = ErrorIcon, fullScreen = false, diff --git a/src/components/ErrorBoundary.tsx b/src/components/ErrorBoundary.tsx index aa9f78ae1..5c20b96d3 100644 --- a/src/components/ErrorBoundary.tsx +++ b/src/components/ErrorBoundary.tsx @@ -27,7 +27,7 @@ class ErrorBoundary extends React.Component< return ( {this.state.errorMessage} @@ -50,7 +50,7 @@ class ErrorBoundary extends React.Component< rel="noopener noreferrer" endIcon={} > - Report Issue + Report issue )} diff --git a/src/components/Home/AccessDenied.tsx b/src/components/Home/AccessDenied.tsx index e2ac2f486..5c103085d 100644 --- a/src/components/Home/AccessDenied.tsx +++ b/src/components/Home/AccessDenied.tsx @@ -15,7 +15,7 @@ export default function AccessDenied() { @@ -38,7 +38,7 @@ export default function AccessDenied() { } diff --git a/src/components/Navigation/Breadcrumbs.tsx b/src/components/Navigation/Breadcrumbs.tsx index c44cee6e9..b12898f8e 100644 --- a/src/components/Navigation/Breadcrumbs.tsx +++ b/src/components/Navigation/Breadcrumbs.tsx @@ -34,7 +34,7 @@ export default function Breadcrumbs(props: BreadcrumbsProps) { return ( } - aria-label="sub-table breadcrumbs" + aria-label="Sub-table breadcrumbs" sx={{ "& ol": { pl: 2, diff --git a/src/components/Navigation/Notifications/index.tsx b/src/components/Navigation/Notifications/index.tsx index ee160e685..162e2a3ea 100644 --- a/src/components/Navigation/Notifications/index.tsx +++ b/src/components/Navigation/Notifications/index.tsx @@ -98,7 +98,7 @@ const Notification = () => { secondary={notification.subtitle} /> - + diff --git a/src/components/Settings/ProjectSettings/About.tsx b/src/components/Settings/ProjectSettings/About.tsx index 84827fc85..de51d51a8 100644 --- a/src/components/Settings/ProjectSettings/About.tsx +++ b/src/components/Settings/ProjectSettings/About.tsx @@ -161,7 +161,7 @@ export default function About() { onClick={checkForUpdate} loading={checkState === "LOADING"} > - Check for Updates + Check for updates ) : ( )} @@ -189,7 +189,7 @@ export default function About() { justifyContent="space-between" > - Firebase Project: {projectId} + Firebase project: {projectId} diff --git a/src/components/Settings/ProjectSettings/Authentication.tsx b/src/components/Settings/ProjectSettings/Authentication.tsx index 5980a7bfd..f4a7af5ca 100644 --- a/src/components/Settings/ProjectSettings/Authentication.tsx +++ b/src/components/Settings/ProjectSettings/Authentication.tsx @@ -21,7 +21,7 @@ export default function Authentication({ return ( <> ({ value: option, diff --git a/src/components/Settings/ProjectSettings/RowyRun.tsx b/src/components/Settings/ProjectSettings/RowyRun.tsx index cf89505e8..5d51d20da 100644 --- a/src/components/Settings/ProjectSettings/RowyRun.tsx +++ b/src/components/Settings/ProjectSettings/RowyRun.tsx @@ -157,7 +157,7 @@ export default function RowyRun({ target="_blank" rel="noopener noreferrer" > - Deploy Instructions + Deploy instructions ); @@ -212,7 +212,7 @@ export default function RowyRun({ onClick={checkForUpdate} loading={checkState === "LOADING"} > - Check for Updates + Check for updates ) : ( deployButton @@ -248,7 +248,7 @@ export default function RowyRun({ setInputRowyRunUrl(e.target.value)} diff --git a/src/components/Settings/ThemeColorPicker.tsx b/src/components/Settings/ThemeColorPicker.tsx index cf43c479b..c22900d93 100644 --- a/src/components/Settings/ThemeColorPicker.tsx +++ b/src/components/Settings/ThemeColorPicker.tsx @@ -51,7 +51,7 @@ export default function ThemeColorPicker({ > - Light Theme + Light theme - Dark Theme + Dark theme {open && ( setOpen(false)} maxWidth="xs" body={ @@ -80,7 +80,7 @@ export default function InviteUser() { setEmail(e.target.value)} diff --git a/src/components/Settings/UserManagement/UserItem.tsx b/src/components/Settings/UserManagement/UserItem.tsx index 2221cd9ea..3fdc086cb 100644 --- a/src/components/Settings/UserManagement/UserItem.tsx +++ b/src/components/Settings/UserManagement/UserItem.tsx @@ -163,9 +163,9 @@ export default function UserItem({ id, user, roles: rolesProp }: User) { - + diff --git a/src/components/Settings/UserSettings/Account.tsx b/src/components/Settings/UserSettings/Account.tsx index 90ef50a3d..96e6958bf 100644 --- a/src/components/Settings/UserSettings/Account.tsx +++ b/src/components/Settings/UserSettings/Account.tsx @@ -27,7 +27,7 @@ export default function Account({ settings }: IUserSettingsChildProps) { diff --git a/src/components/Setup/Step1RowyRun.tsx b/src/components/Setup/Step1RowyRun.tsx index f4d89755e..ee55026e1 100644 --- a/src/components/Setup/Step1RowyRun.tsx +++ b/src/components/Setup/Step1RowyRun.tsx @@ -85,7 +85,7 @@ export default function Step1RowyRun({ rel="noopener noreferrer" endIcon={} > - Deploy Instructions + Deploy instructions ); @@ -122,7 +122,7 @@ export default function Step1RowyRun({ > setRowyRunUrl(e.target.value)} diff --git a/src/components/Setup/Step2ServiceAccount.tsx b/src/components/Setup/Step2ServiceAccount.tsx index 26dc7132e..2582fd567 100644 --- a/src/components/Setup/Step2ServiceAccount.tsx +++ b/src/components/Setup/Step2ServiceAccount.tsx @@ -120,7 +120,7 @@ export default function Step2ServiceAccount({ rel="noopener noreferrer" endIcon={} > - Set Up Service Account + Set up service account - Setup Guide + Setup guide diff --git a/src/components/Setup/Step3ProjectOwner.tsx b/src/components/Setup/Step3ProjectOwner.tsx index 6228e3b8a..73fe92ad0 100644 --- a/src/components/Setup/Step3ProjectOwner.tsx +++ b/src/components/Setup/Step3ProjectOwner.tsx @@ -101,7 +101,7 @@ export default function Step3ProjectOwner({ rel="noopener noreferrer" endIcon={} > - Set Up in Firebase Console + Set up in Firebase Console )} @@ -168,7 +168,7 @@ export default function Step4Rules({ > setNewRules(e.target.value)} multiline @@ -189,7 +189,7 @@ export default function Step4Rules({ onClick={setRules} loading={rulesStatus === "LOADING"} > - Set Firestore Rules + Set Firestore rules {rulesStatus !== "LOADING" && typeof rulesStatus === "string" && ( diff --git a/src/components/SideDrawer/Form/index.tsx b/src/components/SideDrawer/Form/index.tsx index 13b8d54ec..65f639f8e 100644 --- a/src/components/SideDrawer/Form/index.tsx +++ b/src/components/SideDrawer/Form/index.tsx @@ -113,7 +113,7 @@ export default function Form({ values }: IFormProps) { diff --git a/src/components/Table/BulkActions/index.tsx b/src/components/Table/BulkActions/index.tsx index bd015d066..f9b8f9552 100644 --- a/src/components/Table/BulkActions/index.tsx +++ b/src/components/Table/BulkActions/index.tsx @@ -262,11 +262,11 @@ export default function BulkActions({ selectedRows, columns, clearSelection }) { color="secondary" onClick={() => { requestConfirmation({ - title: "Duplicate Rows?", + title: "Duplicate rows?", body: `Are you sure you want to duplicate the ${numSelected} selected row${ numSelected !== 1 ? "s" : "" }?`, - confirm: "Duplicate Rows", + confirm: "Duplicate rows", handleConfirm: handleDuplicate, }); }} @@ -283,11 +283,11 @@ export default function BulkActions({ selectedRows, columns, clearSelection }) { color="secondary" onClick={() => { requestConfirmation({ - title: "Delete Rows?", + title: "Delete rows?", body: `Are you sure you want to delete the ${numSelected} select row${ numSelected !== 1 ? "s" : "" }?`, - confirm: "Delete Rows", + confirm: "Delete rows", handleConfirm: handleDelete, }); }} diff --git a/src/components/Table/CellValidation.tsx b/src/components/Table/CellValidation.tsx index 02fb78dbc..16d9bf04c 100644 --- a/src/components/Table/CellValidation.tsx +++ b/src/components/Table/CellValidation.tsx @@ -67,7 +67,7 @@ export default function CellValidation({ <> } - title="Invalid Data" + title="Invalid data" message="This row will not be saved until all the required fields contain valid data" placement="right" render={({ openTooltip }) => } @@ -82,7 +82,7 @@ export default function CellValidation({ <> } - title="Required Field" + title="Required field" message="This row will not be saved until all the required fields contain valid data" placement="right" render={({ openTooltip }) => } diff --git a/src/components/Table/ColumnHeader.tsx b/src/components/Table/ColumnHeader.tsx index fb33e31cd..c5e720b12 100644 --- a/src/components/Table/ColumnHeader.tsx +++ b/src/components/Table/ColumnHeader.tsx @@ -263,7 +263,7 @@ export default function DraggableHeaderRenderer({ title={ isAsc ? "Unsort" - : `Sort by ${isDesc ? "Ascending" : "Descending"}` + : `Sort by ${isDesc ? "ascending" : "descending"}` } > ({ aria-label={ isAsc ? "Unsort" - : `Sort by ${isDesc ? "Ascending" : "Descending"}` + : `Sort by ${isDesc ? "ascending" : "descending"}` } className={clsx(classes.sortIcon, isAsc && classes.sortIconAsc)} > @@ -290,7 +290,7 @@ export default function DraggableHeaderRenderer({ (column as any).type ))) && ( - + handleChange("defaultValue.type")(e.target.value)} fullWidth diff --git a/src/components/Table/ColumnMenu/FieldSettings/index.tsx b/src/components/Table/ColumnMenu/FieldSettings/index.tsx index 917351e08..ce388fe7a 100644 --- a/src/components/Table/ColumnMenu/FieldSettings/index.tsx +++ b/src/components/Table/ColumnMenu/FieldSettings/index.tsx @@ -91,7 +91,7 @@ export default function FieldSettings(props: IMenuModalProps) { sx={{ borderTop: 1, borderColor: "divider", pt: 3 }} > - Rendered Field Config + Rendered field config {createElement(rendedFieldSettings, { config: newConfig, @@ -114,7 +114,7 @@ export default function FieldSettings(props: IMenuModalProps) { onClick: () => { if (showRebuildPrompt) { requestConfirmation({ - title: "Deploy Changes", + title: "Deploy changes", body: "You have made changes that affect the behavior of the cloud function of this table, Would you like to redeploy it now?", confirm: "Deploy", cancel: "Later", diff --git a/src/components/Table/ColumnMenu/FieldsDropdown.tsx b/src/components/Table/ColumnMenu/FieldsDropdown.tsx index 766ae6723..43fc77025 100644 --- a/src/components/Table/ColumnMenu/FieldsDropdown.tsx +++ b/src/components/Table/ColumnMenu/FieldsDropdown.tsx @@ -49,8 +49,8 @@ export default function FieldsDropdown({ {option.label} )} - label={label || "Field Type"} - labelPlural="Field Types" + label={label || "Field type"} + labelPlural="field types" TextFieldProps={{ hiddenLabel: hideLabel, helperText: value && getFieldProp("description", value), diff --git a/src/components/Table/ColumnMenu/NameChange.tsx b/src/components/Table/ColumnMenu/NameChange.tsx index 04dbbf736..a23206723 100644 --- a/src/components/Table/ColumnMenu/NameChange.tsx +++ b/src/components/Table/ColumnMenu/NameChange.tsx @@ -19,7 +19,7 @@ export default function NameChange({ return ( { diff --git a/src/components/Table/ColumnMenu/NewColumn.tsx b/src/components/Table/ColumnMenu/NewColumn.tsx index 6f00e1a6e..78ea9b7c6 100644 --- a/src/components/Table/ColumnMenu/NewColumn.tsx +++ b/src/components/Table/ColumnMenu/NewColumn.tsx @@ -43,7 +43,7 @@ export default function NewColumn({ return ( setColumnLabel(e.target.value)} @@ -67,7 +67,7 @@ export default function NewColumn({ value={fieldKey} variant="filled" id="fieldKey" - label="Field Key" + label="Field key" type="text" fullWidth onChange={(e) => setFieldKey(e.target.value)} diff --git a/src/components/Table/ColumnMenu/TypeChange.tsx b/src/components/Table/ColumnMenu/TypeChange.tsx index 6e9a227b2..93a2fafb9 100644 --- a/src/components/Table/ColumnMenu/TypeChange.tsx +++ b/src/components/Table/ColumnMenu/TypeChange.tsx @@ -18,7 +18,7 @@ export default function FormDialog({ return ( } actions={{ primary: { diff --git a/src/components/Table/EmptyTable.tsx b/src/components/Table/EmptyTable.tsx index 7c82e1fdc..0fb9944d0 100644 --- a/src/components/Table/EmptyTable.tsx +++ b/src/components/Table/EmptyTable.tsx @@ -19,7 +19,7 @@ export default function EmptyTable() { <>
- Get Started + Get started There is existing data in the Firestore collection: @@ -51,7 +51,7 @@ export default function EmptyTable() { <>
- Get Started + Get started There is no data in the Firestore collection: @@ -113,7 +113,7 @@ export default function EmptyTable() { } disabled={!columnMenuRef?.current} > - Add Column + Add column diff --git a/src/components/Table/Filters/index.tsx b/src/components/Table/Filters/index.tsx index f1a6ca06a..c8aac8eea 100644 --- a/src/components/Table/Filters/index.tsx +++ b/src/components/Table/Filters/index.tsx @@ -455,7 +455,7 @@ const Filters = () => { SelectProps={{ displayEmpty: true }} > - Select Column + Select column {filterColumns.map((c) => ( @@ -483,7 +483,7 @@ const Filters = () => { SelectProps={{ displayEmpty: true }} > - Select Condition + Select condition {operators.map((operator) => ( diff --git a/src/components/Table/FinalColumnHeader.tsx b/src/components/Table/FinalColumnHeader.tsx index 98b90175d..75eb32a95 100644 --- a/src/components/Table/FinalColumnHeader.tsx +++ b/src/components/Table/FinalColumnHeader.tsx @@ -69,7 +69,7 @@ const FinalColumnHeader: Column["headerRenderer"] = ({ column }) => { className={classes.button} startIcon={} > - Add Column + Add column ); diff --git a/src/components/Table/HiddenFields.tsx b/src/components/Table/HiddenFields.tsx index 04881fa22..c8455aa3e 100644 --- a/src/components/Table/HiddenFields.tsx +++ b/src/components/Table/HiddenFields.tsx @@ -140,7 +140,7 @@ export default function HiddenFields() { }, } as any)} label="Hidden fields" - labelPlural="Fields" + labelPlural="fields" options={tableColumns} value={hiddenFields ?? []} onChange={setHiddenFields} diff --git a/src/components/Table/Settings/Menu.tsx b/src/components/Table/Settings/Menu.tsx index 532c8997a..010a03d8e 100644 --- a/src/components/Table/Settings/Menu.tsx +++ b/src/components/Table/Settings/Menu.tsx @@ -24,7 +24,7 @@ export default function SettingsMenu({ modal, setModal }) { return (
- Webhook Type + Webhook type