Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxros::observable::from_topic does not react on ROS problems. #20

Open
henrik7264 opened this issue Aug 31, 2019 · 2 comments
Open

rxros::observable::from_topic does not react on ROS problems. #20

henrik7264 opened this issue Aug 31, 2019 · 2 comments

Comments

@henrik7264
Copy link
Collaborator

rxros::observable::from_topic does not react on ROS problems such as topic termination or network problems. An on_error event should be emitted if such problems appears.

@gavanderhoorn
Copy link
Member

such as topic termination

just curious: @henrik7264: how would you detect 'topic termination'? Do you mean the case where a single publisher is publishing to a topic and it stops doing that?

How would you distinguish that from a publisher that is just slow?

It's possible to interrogate the master to see whether there are still publishers for a specific topic, but that will introduce a rather significant overhead (as it has to be done periodically, there are no events for this).

@henrik7264
Copy link
Collaborator Author

henrik7264 commented Sep 8, 2019

@gavanderhoorn - yes it is a good question. I actually don't known how to handle it currently. I just remembered for a long time ago I read that is was possible to terminate a topic. I have never tried this and I also don't know how to handle it in a ROS node.

You a right that this could easily become an expensive operation if there are no events/triggers associated to the termination of the topic. Then we would have to fallback to timers + checks as you describe. This could easily become a nasty business.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants