-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fzf-lua text invisible #283
Comments
relevant part in fzf lua docs https://github.com/ibhagwan/fzf-lua?tab=readme-ov-file#fzf-colors |
discussion about it on the fzf Lua repo ibhagwan/fzf-lua#1325 (comment) |
By any chance does the override you mention above work without you setting a foreground for Because that highlight group links to |
doesn't work, here is the result without fg: yes the comment you left on the other issue i thought it was for me, because the tag @. mvllow looks like @mirsella lol, but i was answering to the message you left there not this one. thanks for looking into it ! |
I don't have FzfLua installed (I use Telescope)... so I can't check necessarily what it's doing... I can only go by the documentation. Let me look into things a bit more. |
|
I am in the middle of working on a fix for this now hopefully. Quick question.. Edited 30 seconds later: God I'm blind.... lol 😝 |
yes I do ! |
Yeah I figured that out.... says right in the one screenshot... shakes head 😆 |
Do you have any config customization you've done specifically for FzfLua, or are you just using LazyVim's default config for it? |
Just submitted the PR that should be a good fix for this.. you can test it, by modifying your rose-pine config with the following: {
-- 'rose-pine/neovim',
'sjclayton/rose-pine',
branch = 'fix-fzflua-invisible-selection',
-- rest of your rose-pine config below
}, Let me know how it goes.. 😄 |
hey ! thanks a lot ! sadly this still doesn't work (yes im on your branch with lazy.nvim) |
Wait what, it work when my config is
but
doesn't ! |
Does it work if you pass in Do you have a plugin spec for rose-pine somewhere else in your config or did you just modify the existing one you had? |
That explains why it wasn't working... If you change one reference to my fork of rose-pine you have to change all other references to my fork as well or lazy doesn't know which to prioritize. So that dependencies line would need to be |
Neovim version (nvim -v)
NVIM v0.11.0-dev-358+g6a886a251
Terminal / multiplexer
konsole
Describe the bug
hello
![1](https://private-user-images.githubusercontent.com/45905567/346712534-d464b35a-03d1-4b59-9399-9d2257b31ebf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4MTE5NTEsIm5iZiI6MTcyMTgxMTY1MSwicGF0aCI6Ii80NTkwNTU2Ny8zNDY3MTI1MzQtZDQ2NGIzNWEtMDNkMS00YjU5LTkzOTktOWQyMjU3YjMxZWJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI0VDA5MDA1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU4Y2UyNWM3YTA1ZDkwNjVlODRhYmEzYmQwOGY2YzQ2YzUxYmE3MmRhMjdiY2E2ZWZmMzdjOWIzMGM3Y2I1ODMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sCbG2gCG8StCdDz45VRF2WP-ZImFx6f8lpLY3WuWuvY)
![2](https://private-user-images.githubusercontent.com/45905567/346712531-b189e9f0-fb17-465b-83eb-fe55d93c5951.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4MTE5NTEsIm5iZiI6MTcyMTgxMTY1MSwicGF0aCI6Ii80NTkwNTU2Ny8zNDY3MTI1MzEtYjE4OWU5ZjAtZmIxNy00NjViLTgzZWItZmU1NWQ5M2M1OTUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI0VDA5MDA1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQxYmYzZDM2ODJhNzJmNDZmYzUyNjEzM2RjMjY0NjY3ZWRmMTc3ZDY0Y2JiNDIwOTdiODgxNWFiNGY5MjM1ODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tj2kLWS9kGGF9ZOQjUTbd7ieD8p1niISzO1vVZ5r8xo)
when using fzf lua most of the item listing are invisible
I'm not sure if it's something we can fix in rose pine, but I don't know where to find help otherwise, maybe this can be added as a plugin like some other in the wiki
Repro
The text was updated successfully, but these errors were encountered: