-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: maybe set DiagnosticOk highlights #255
Comments
Do you have a screenshot/example of when this highlight is used? Happy to add support here but not sure how to test |
I also don't mind the color of which-key.nvim is now using |
You can test by checking out the highlights section of the diagnostic help page:
|
We will have to wait for @mvllow to weigh in more on this... like I said I am fine with using the green color But like I said, I'd like to see if there is anything @mvllow has to say about this first. |
Ideally we would use a colour from our existing palette but we do have this super secret leaf green |
I am going to do some testing, and play around with that color a bit and see what it looks like applying it to various things in my config... and I will post the results here. |
From the little bit of early testing I've done so far.... the leaf green color looks OK.... it's still a bit dark for my liking, in order to have it look good across all variants I think the saturation should be increased about 10%... so it would end up as |
I found |
I just tried it out, it looks ok... I still think If you think Here is a screenshot of all three side-by-side, let me know what you think. EDIT: I just tried the new one - |
I think I misspoke initially. From our branding material, Edit for clarity: my current proposal is |
I'm good with your current proposal. I was also wondering if this would mean this color set is added to the palette as a named color or no? If so I would just call it 'leaf' 😃 |
If you want to add leaf to the palette file that’s fine with me. I don’t see it going much further than our Neovim theme for now but it doesn’t hurt :) |
I will be submitting additional PR's that rely on #290, to update some existing plugin support to include the new color. Don't get me wrong, I love the palette, however I think there are situations where it can be hard to adequately achieve proper styling with only 6 colors... Neovim is one of those situations. I wasn't thinking you were going to necessarily add Thanks for your input with this!! 💯 |
Describe the solution you'd like
Hey, this is minor but I by chance saw that the DiagnosticOk highlight isn't set by the colorscheme. Right now it uses guifg=NvimLightGreen. I don't mind the color, but the DiagnosticVirtualTextOk highlight won't get a blended background like the other 4 ones :)
Additional context
The text was updated successfully, but these errors were encountered: