Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align on Transport GID and Liveliness GUID #148

Open
Yadunund opened this issue Apr 4, 2024 · 0 comments
Open

Align on Transport GID and Liveliness GUID #148

Yadunund opened this issue Apr 4, 2024 · 0 comments
Labels
backlog Long-term improvement or addition

Comments

@Yadunund
Copy link
Member

Yadunund commented Apr 4, 2024

At present, entities like pub/subs are assigned an rmw_gid_t gid value and this is attached to the payload. However, GraphCache relies on a std::size guid to unique identify entities. The size_t is a std::hash of the liveliness token which is now unique.

It would be best if we could combine the two somehow.

  1. Either derive the 16byte GID from the liveliness token or
  2. Append the 16byte GID to the liveliness token.

Personally I'd prefer 1) to since the liveliness tokens are already several bytes.

@clalancette clalancette added the backlog Long-term improvement or addition label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Long-term improvement or addition
Projects
None yet
Development

No branches or pull requests

2 participants