Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rcl call rmw_set_log_severity #915

Open
christophebedard opened this issue Apr 28, 2021 · 2 comments · May be fixed by #918
Open

Make rcl call rmw_set_log_severity #915

christophebedard opened this issue Apr 28, 2021 · 2 comments · May be fixed by #918
Labels
more-information-needed Further information is required

Comments

@christophebedard
Copy link
Member

christophebedard commented Apr 28, 2021 •
edited
Loading

Feature request

Feature description

rmw_set_log_severity was added in:

It's implemented by the rmw implementations (Cyclone DDS, FastDDS, Connext), but it doesn't really seem to be used anywhere/by anything.

It would make sense to have rcl (e.g. rcl_logging_configure()?) call rmw_set_log_severity() along with its own logging level configuration. Is there any reason why these two shouldn't be connected?

Implementation considerations

TBD
@christophebedard christophebedard changed the title Make rcl_logging_configure call rmw_set_log_severity Make rcl call rmw_set_log_severity Apr 28, 2021
@fujitatomoya
Copy link
Collaborator

i think it makes sense, probably setting default log level during Context::init?

@christophebedard christophebedard linked a pull request May 2, 2021 that will close this issue
Draft
@christophebedard
Copy link
Member Author

christophebedard commented May 2, 2021 •
edited
Loading

assuming you mean rclcpp::Context::init, yeah it does call rcl_init and logging-related rcl_* functions.

I opened a simple draft PR just to have a concrete proposition: #918

@christophebedard christophebedard mentioned this issue May 10, 2021
Open
@clalancette clalancette added the more-information-needed Further information is required label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
more-information-needed Further information is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set rmw log severity christophebedard/rcl
4 participants
@clalancette @jacobperron @christophebedard @fujitatomoya