Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix login by using new GitHub methods #271

Open
wjwwood opened this issue Feb 7, 2020 · 1 comment
Open

fix login by using new GitHub methods #271

wjwwood opened this issue Feb 7, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@wjwwood
Copy link
Member

wjwwood commented Feb 7, 2020

GitHub deprecated the use of access_token for queries, which this site was using, see:

https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters

We were getting emails like this:

Hello there!

On February 7th, 2020 at 08:56 (UTC) your application (ROS2 Design Website) used an access token (with the User-Agent Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0) as part of a query parameter to access an endpoint through the GitHub API.

https://api.github.com/repositories/14241623/pulls/269/files

Please use the Authorization HTTP header instead as using the `access_token` query parameter is deprecated.

Depending on your API usage, we'll be sending you this email reminder once every 3 days for each token and User-Agent used in API calls made on your behalf.
Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.

Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.

Thanks,
The GitHub Team

I opened #270 to disable login, until we have time to implement a new login mechanism.

@wjwwood wjwwood added enhancement New feature or request help wanted Extra attention is needed labels Feb 7, 2020
@kyrofa
Copy link
Member

kyrofa commented Feb 7, 2020

We were getting emails like this:

Haha, that's one way to get people to stop using deprecated stuff. Annoy them to death.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants