Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Findassimp.cmake #39

Open
jvgomez opened this issue Jan 6, 2016 · 1 comment
Open

Include Findassimp.cmake #39

jvgomez opened this issue Jan 6, 2016 · 1 comment

Comments

@jvgomez
Copy link

jvgomez commented Jan 6, 2016

Is there any reason not to include here the Findassimp.cmake file? It is not installed with the library and I have to use PkgConfig.

Thanks.
@wjwwood
Copy link
Member

wjwwood commented Jan 7, 2016

I would say that assimp would distribute that file since they have it in their source. I consider taking a pull request to this repository with that module in it, so long as an appropriate issue is filed upstream to correct the issue that no cmake file is installed with assimp. See: https://github.com/ros/cmake_modules/blob/0.4-devel/CONTRIBUTING.md#long-term-contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wjwwood @jvgomez