-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ros2] library suffix hack #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes it is correct, but this lgtm. pluginlib
does some tricks to handle this too.
Yeah it seems correct for many external projects. Out of curiosity, do you know why we don't produce libraries with the trailing |
I guess because cmake doesn't do it for you. It's purely a convention that we just didn't opt into. Also it's not required most of the time on Linux and macOS. It's most problematic on Windows which often builds into separate folders anyways. For distribution on Windows specifically it might be useful when you want to side-by-side install the release and debug versions. |
return ".dll"; | ||
#else | ||
return Poco::SharedLibrary::suffix(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment from @dirk-thomas :
"Wouldn't it be nice if the debug shared libraries could be loaded for debugging?"
To keep in mind when thinking about addressing #31, it would be great to give users control about what libraries to find and load rather than making the decision for them one way or another
workaround for #31
See #31 for original issue description and a potential real fix description.
This is needed for #59 tests to pass in Debug mode