Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply remappings to base topic before creating transport-specific topics #326

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Apply remappings to base topic before creating transport-specific topics #326

merged 3 commits into from
Oct 2, 2024

Conversation

bjsowa
Copy link
Contributor

@bjsowa bjsowa commented Sep 30, 2024 •
edited
Loading

Related issues:
#237
#171
#80 (nvm, this is for ros1)
ros-perception/image_pipeline#839

ahcorde
ahcorde requested changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are conflicts

@bjsowa
Copy link
Contributor Author

bjsowa commented Oct 2, 2024

There are conflicts

fixed

@bjsowa bjsowa requested a review from ahcorde October 2, 2024 14:51
@ahcorde
Copy link
Collaborator

ahcorde commented Oct 2, 2024

Pulls: #326
Gist: https://gist.githubusercontent.com/ahcorde/00fc5830f0d254b139c3d425891a1b42/raw/73e89122387ef0668397e41386a09ad1e2bdfba8/ros2.repos
BUILD args: --packages-above-and-dependencies image_transport --packages-above-and-dependencies image_transport
TEST args: --packages-above image_transport --packages-above image_transport
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14649

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit ea7589a into ros-perception:rolling Oct 2, 2024
2 checks passed
@bjsowa
Copy link
Contributor Author

bjsowa commented Oct 2, 2024

@ahcorde Can this and/or #325 be backported to Jazzy?

@bjsowa bjsowa deleted the resolve-topic-names branch October 3, 2024 00:03
@ahcorde
Copy link
Collaborator

ahcorde commented Oct 4, 2024

I can backport #325, but this one looks like a behavioral change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees

@bjsowa bjsowa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjsowa @ahcorde