Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtime Publisher - Select one behavior (Polling or NonPolling) and remove the other one #212

Open
firesurfer opened this issue Nov 28, 2024 · 2 comments

Comments

@firesurfer
Copy link
Contributor

I just refactored the RealtimePublisher in #211 and I am wondering if we really need these two different behaviors of the RT publisher.

They make the code harder to read and maintain. In accordance with #199 I would suggest to use the non polling behavior and remove the other one.

Perhaps someone could point out a use case where one or the other is preferable?

@firesurfer
Copy link
Contributor Author

Only place in ros-controls the NON_POLLING define is set is in the tests of this repository:

https://github.com/search?q=org%3Aros-controls%20NON_POLLING&type=code

If I search more general I can only find it in this repo and forks of it
https://github.com/search?q=+NON_POLLING+AND+realtime_tools&type=code

@bmagyar
Copy link
Member

bmagyar commented Dec 18, 2024

Sorry for being late on this, @christophfroehlich has brought this to the Working Group meeting.

I also agree that we should strive for using non-polling everywhere, especially now that it can be implemented in an elegant and transparent way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants