Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practice for updating #7

Open
LukasCBossert opened this issue Apr 18, 2023 · 4 comments
Open

Best practice for updating #7

LukasCBossert opened this issue Apr 18, 2023 · 4 comments

Comments

@LukasCBossert
Copy link
Contributor

While the doom-nano-modeline-package is updated automatically using doom upgrade, what is a best practice for updating this repository? Currently I would use the content of https://raw.githubusercontent.com/ronisbr/doom-nano-themes/main/doom-nano-dark-theme.el and overwrite my locally stored files. Probably I could also have this repo in the config-folder and use git pull.... But is there a better/automatic approach updating the files?

@ronisbr
Copy link
Owner

ronisbr commented Apr 18, 2023

Hi @LukasCBossert ! That is a good question, and I do not have a good answer :(

The files must be in ./.doom.d/themes/. Maybe you can use doom upgrade but symlink the files to that directory? Notice that everything will be way easier when the theme is good enough to be submitted to doom-themes repository.

If anyone has a better idea how to automate the upgrade process, please, let me know!

@LukasCBossert
Copy link
Contributor Author

Hi @ronisbr , thanks for the quick answer.

Stupid question: Why is the same approach not working for the themes like for the modeline:

(package! doom-nano-modeline
  :recipe (:host github
  :repo "ronisbr/doom-nano-modeline"))

(in the packages.el-file).

@ronisbr
Copy link
Owner

ronisbr commented Apr 18, 2023

That's not stupid at all!

The problem seems with how doom-themes is built. For some reason, the themes must be inside .doom.d/themes, otherwise they did not work. Even if you load the file manually, I could not make it work. However, I have very little experience and maybe someone can help us to improve the installation process :)

@LukasCBossert
Copy link
Contributor Author

ok, sounds logically. Yeah, I am (also) a not so experienced but enthusiastic user.
Hopefully there is someday the integration of this theme in the doom-themes..... or @hlissner will be able to include nano-emacs into Doom entirely (cf. doomemacs/doomemacs#4413)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants