Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit .project.json when searching for a project file #895

Open
AridAjd opened this issue Mar 21, 2024 · 3 comments
Open

Omit .project.json when searching for a project file #895

AridAjd opened this issue Mar 21, 2024 · 3 comments
Labels
scope: cli Relevant to the Rojo CLI size: small type: enhancement Feature or improvement that should potentially happen

Comments

@AridAjd
Copy link

AridAjd commented Mar 21, 2024

is it possible that we do rojo [command] anotherFile instead of rojo [command] anotherFile.project.json? Typing out .project.json is longer.
Plus, it'd make development faster by not wasting the time on typing.

@Dekkonot Dekkonot added type: enhancement Feature or improvement that should potentially happen scope: cli Relevant to the Rojo CLI size: small labels Mar 21, 2024
@Dekkonot
Copy link
Member

I don't see a compelling reason to not do this, provided we default to checking for anotherFile before checking for anotherFile.project.json.

@AridAjd
Copy link
Author

AridAjd commented Mar 21, 2024

I don't see a compelling reason to not do this, provided we default to checking for anotherFile before checking for anotherFile.project.json.

Imo, the file should still be named anotherFile.project.json but it'd first check if there's a project file with the name provided. If there is, it'll just continue doing the other activities.

@Dekkonot
Copy link
Member

Dekkonot commented Mar 21, 2024

Sorry, that is actually what I meant I just mixed up the order of them! That's on me, haha.

EDIT: No nevermind I actually just misread your message. No, I think checking for the exact name is the only backwards compatible behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: cli Relevant to the Rojo CLI size: small type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Development

No branches or pull requests

2 participants