Plugin doesn't report Workspace.PlayerCharacterDestroyBehavior failing to be set

[nezuo]

Reproduction steps:

1. Initialize a new Rojo project.
2. Set the Workspace.PlayerCharacterDestroyBehavior to "Enabled" in the project file.
3. Run rojo serve.
4. Open a blank studio place (don't build this project because it will have the updated property) and sync.
5. Rojo won't show a warning.

This issue may exist for more properties but this is the one I tested.

[kennethloeffler]

This occurs because Workspace.PlayerCharacterDestroyBehavior is unreadable from Lua. In the plugin's diff function, unreadable properties are skipped:

rojo/plugin/src/Reconciler/diff.lua

Lines 148 to 184 in 8f9e307

	local changedProperties = {}
	for propertyName, virtualValue in pairs(virtualInstance.Properties) do
	local getProperySuccess, existingValueOrErr = getProperty(instance, propertyName)
	if getProperySuccess then
	local existingValue = existingValueOrErr
	local decodeSuccess, decodedValue = decodeValue(virtualValue, instanceMap)
	if decodeSuccess then
	if not trueEquals(existingValue, decodedValue) then
	Log.debug(
	"{}.{} changed from '{}' to '{}'",
	instance:GetFullName(),
	propertyName,
	existingValue,
	decodedValue
	)
	changedProperties[propertyName] = virtualValue
	end
	else
	Log.warn(
	"Failed to decode property {}.{}. Encoded property was: {:#?}",
	virtualInstance.ClassName,
	propertyName,
	virtualValue
	)
	end
	else
	local err = existingValueOrErr
	if err.kind == Error.UnknownProperty then
	Log.trace("Skipping unknown property {}.{}", err.details.className, err.details.propertyName)
	else
	Log.trace("Skipping unreadable property {}.{}", err.details.className, err.details.propertyName)
	end
	end
	end

Because properties unreadable from Lua are skipped here, they never make it to patch application, which is where the "unapplied patch" logic actually lives, which is what informs the patch visualizer warnings:

rojo/plugin/src/Reconciler/applyPatch.lua

Lines 195 to 214 in 8f9e307

	if update.changedProperties ~= nil then
	for propertyName, propertyValue in pairs(update.changedProperties) do
	local decodeSuccess, decodedValue = decodeValue(propertyValue, instanceMap)
	if not decodeSuccess then
	unappliedUpdate.changedProperties[propertyName] = propertyValue
	partiallyApplied = true
	continue
	end
	local setPropertySuccess = setProperty(instance, propertyName, decodedValue)
	if not setPropertySuccess then
	unappliedUpdate.changedProperties[propertyName] = propertyValue
	partiallyApplied = true
	end
	end
	end
	if partiallyApplied then
	table.insert(unappliedPatch.updated, unappliedUpdate)
	end

I think to fix this, we'll have to track any properties we were unable to diff in the same way we track which properties we were unable to set.