-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin doesn't report Workspace.PlayerCharacterDestroyBehavior
failing to be set
#874
Comments
This occurs because rojo/plugin/src/Reconciler/diff.lua Lines 148 to 184 in 8f9e307
Because properties unreadable from Lua are skipped here, they never make it to patch application, which is where the "unapplied patch" logic actually lives, which is what informs the patch visualizer warnings: rojo/plugin/src/Reconciler/applyPatch.lua Lines 195 to 214 in 8f9e307
I think to fix this, we'll have to track any properties we were unable to diff in the same way we track which properties we were unable to set. |
Reproduction steps:
Workspace.PlayerCharacterDestroyBehavior
to"Enabled"
in the project file.rojo serve
.This issue may exist for more properties but this is the one I tested.
The text was updated successfully, but these errors were encountered: