Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email case insensitivity on login #12

Open
DNGros opened this issue Oct 10, 2017 · 1 comment
Open

Email case insensitivity on login #12

DNGros opened this issue Oct 10, 2017 · 1 comment

Comments

@DNGros
Copy link

DNGros commented Oct 10, 2017

The user login email is case sensitive resulting incorrect account-not-found errors or forcing the user to try variations of their email until they find the how they entered it inicially
It could likely be fixed with a change to

user = User.query.filter_by(email=email).first()

to do a case insensitive query.
(this seems fairly easy to do https://stackoverflow.com/questions/16573095/case-insensitive-flask-sqlalchemy-query).

It should also probably be investigated whether the corporate login has this same issue. The password reset link doesn't seem to have this issue, but I am not sure why.

@rohitdatta
Copy link
Owner

Agreed. We're going to change this to instead .lower() on account creation, which won't deploy for myHackTX 2017, but will prevent duplicate accounts in the system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants