Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTypes #6

Open
AminHP opened this issue Aug 13, 2018 · 5 comments
Open

FileTypes #6

AminHP opened this issue Aug 13, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@AminHP
Copy link

AminHP commented Aug 13, 2018

First of all, thank you for this useful library I like that and it is what I really wanted :)

Why don't you create an extension->record dictionary or factory so we can select our desired records instead of defining them from scratch?
You have just obsoleted everything in FileTypes and we have to create our records manually.
It would be better if there was a dictionary or factory (or some methods like them) to store all records, then we can just select them easily.

@rocketRobin
Copy link
Owner

Thank you for your advice. Next I will consider about this :D

@rocketRobin rocketRobin added the enhancement New feature or request label Aug 14, 2018
@AminHP
Copy link
Author

AminHP commented Aug 14, 2018

Thanks for your quick reply. I can help you and contribute if you want.

@rocketRobin
Copy link
Owner

Yes, I want, that's great. Thank you very much!

@igornaumoski-sopro
Copy link

igornaumoski-sopro commented Nov 4, 2022

Do you have at least list of hex codes for common file types? How would I know what hex to use for file type? I can't find any documentation on this or what those hex codes mean. Only if I change some it doesn't work.

@rocketRobin
Copy link
Owner

rocketRobin commented Nov 5, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants