Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to make in ubuntu lts #99

Open
W0jtini opened this issue Jun 28, 2024 · 2 comments
Open

Unable to make in ubuntu lts #99

W0jtini opened this issue Jun 28, 2024 · 2 comments

Comments

@W0jtini
Copy link

W0jtini commented Jun 28, 2024

g++ -DHAVE_CONFIG_H -I. -I./cfg -Wall -Werror -Wextra -Wreturn-type -fno-strict-aliasing -D_FILE_OFFSET_BITS=64 -D_LARGE_FILE -I/usr/include/libusb-1.0 -g -O2 -MT main.o -MD -MP -MF .deps/main.Tpo -c -o main.o main.cpp
main.cpp: In function ‘bool _Z9mergeBootv.part.0()’:
main.cpp:1493:43: error: ‘%s’ directive output may be truncated writing up to 557 bytes into a region of size 5 [-Werror=format-truncation=]
1493 | snprintf(buffer, sizeof(buffer), "%s", chip);
| ^~
......
1534 | chipType = convertChipType(chip + 2);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/stdio.h:894,
from DefineHeader.h:3,
from main.cpp:11:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:71:35: note: ‘__builtin_snprintf’ output between 1 and 558 bytes into a destination of size 5
71 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
72 | __glibc_objsize (__s), __fmt,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
73 | __va_arg_pack ());
| ~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[1]: *** [Makefile:491: main.o] Error 1
make[1]: Leaving directory '/home/wojtek/rkdeveloptool'
make: *** [Makefile:511: all-recursive] Error 1

@elektronxyz
Copy link

Just add "-Wno-format-truncation" on line 6 of Makefile.am to suppress this error:

"AM_CPPFLAGS = -Wall -Werror -Wextra -Wreturn-type -Wno-format-truncation -fno-strict-aliasing -D_FILE_OFFSET_BITS=64 -D_LARGE_FILE $(LIBUSB1_CFLAGS)"

@capton586
Copy link

Edit file main.cpp in line 1493 like this:

static inline uint32_t convertChipType(const char* chip) {
        char buffer[512];
        memset(buffer, 0, sizeof(buffer));
        if (strlen(chip) < sizeof(buffer))  {
                snprintf(buffer, sizeof(buffer), "%s", chip);
        } else {
                strncpy(buffer, chip, sizeof(buffer) - 1);
                buffer[sizeof(buffer) - 1] = '\0';
        }
        return buffer[0] << 24 | buffer[1] << 16 | buffer[2] << 8 | buffer[3];
}

It works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants