New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible CMake improvements #1

Open

traversaro opened this issue Jan 28, 2019 · 1 comment

Member

traversaro commented Jan 28, 2019

The current structure of the library has several CMake-related things that could be improved:

The version of the library is not explicitly exported
The exported target does not include a namespace
Target definition is duplicated, once in the source code and one in the CommonClassesConfig.cmake file.

I would suggest to take inspiration from https://github.com/robotology/how-to-export-cpp-library for the details on how to export a C++ library.

Member

drdanz commented Jan 29, 2019

I strongly recommend to make ycm a hard dependency of this repository.

aerydna mentioned this issue

[ANNOUNCEMENT] CMAKE improver needed (we need YOU) #7

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment